Skip to content

Comments

Refactor code to avoid cyclic references#173

Merged
s-vitaliy merged 2 commits intomainfrom
fix-job-builder-interface
Jan 7, 2026
Merged

Refactor code to avoid cyclic references#173
s-vitaliy merged 2 commits intomainfrom
fix-job-builder-interface

Conversation

@s-vitaliy
Copy link
Contributor

Part of #144

Scope

Implemented:

  • Implemented a refactoring where code was partially moved to a higher level to avoid cyclic imports in future commits.
  • Added the JobBuilder mock.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy marked this pull request as ready for review January 7, 2026 10:43
@s-vitaliy s-vitaliy requested a review from a team as a code owner January 7, 2026 10:43
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

go-test-coverage report:

  below threshold:						coverage:	threshold:
  configuration/configuration.go				 0.0% (0/18)	70%
  services/controllers/stream/basic_job_configurator.go		 0.0% (0/3)	70%
  telemetry/app_metrics.go					 0.0% (0/9)	70%

Package coverage threshold (70%) satisfied:	FAIL
  below threshold:				coverage:	threshold:
  telemetry					 0.0% (0/9)	70%
  configuration					 0.0% (0/18)	70%

Total coverage threshold (75%) satisfied:	FAIL
Total test coverage: 64.7% (119/184)

Files with uncovered lines:
  file:								coverage:	uncovered lines:
  configuration/configuration.go				0%		17-20 22-24 27-36 39-41 43-47 52-55 60
  services/controllers/stream/basic_job_configurator.go		0%		14-15 18-19 22-26
  services/controllers/stream/stream_definition.go		80%		66-68
  services/controllers/stream/unstructured_wrapper.go		75.6%		41-43 45-47 50-52 64-66 90-92 123-125 129-131 134-136 139-141 144-146 149-151 158-160 162-164 167-169 172-174 182-187 194-196 198-200 207-212
  services/controllers/stream_class/stream_class.go		79.4%		40-42 47-49 67-70 90-93 98-106 141-144
  telemetry/app_metrics.go					0%		18-22 24 53-56 60-63 65

@s-vitaliy s-vitaliy merged commit 96f1839 into main Jan 7, 2026
1 check passed
@s-vitaliy s-vitaliy deleted the fix-job-builder-interface branch January 7, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants